Conversation
…resource handling
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the credential refresh process in the az aro update command so that it tolerates clusters with invalid machinesets by filtering out worker profiles with nonexistent subnets.
- Filter out None values from the worker_profiles_status collection instead of propagating them.
- Update the set comprehension for worker_subnets to include a None check.
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
tsatam
changed the title
az aro update: Fix credential refresh to handle clusters with invalid machinesets az aro update: Fix credential refresh to handle clusters with invalid machinesets
kairu-ms
approved these changes
Jun 4, 2025
jsntcy
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aro updateDescription
az aro updateto tolerate clusters with invalid machinesets - these are propagated on the ARO cluster resource under theworkerProfilesStatusfield, and currently cause the CLI to fail due to missing a valid subnet property, with the following error:Testing Guide
Against an ARO cluster containing a machineset considered "invalid" (has 0 ready machines):
az aro update --refresh-credentialson the latest Azure CLI release - will failaz aro update --refresh-credentialswith this change - should passHistory Notes
[ARO]
az aro update: Fix credential refresh to handle clusters with invalid machinesetsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.